What is your favorite old school console?

The SNES has better versions of practically every great NES game you listed. Super Mario World/Super Mario RPG, Super Punch-Out!!, TMNT: Turtles in Time, Zelda: A Link to the Past, Super Metroid, Final Fantasy 3(6), etc. NES gets points for being groundbreaking, but as far as raw gameplay and enjoyability goes, the SNES wins hands down. If you put any of my examples here against the corresponding examples you listed, there's no contest for most of them (the only legit argument I could see would be with SMB3 vs SMW, but considering SMB3 is almost universally considered the best game for the NES, and SMW was average at best for the SNES...). The NES paved the way for the excellence that was the SNES.

Gameboy color.

Pokemon?

Gameboy color.

I'm pretty sure this is considered a handheld and not a console.

Always thought it was considered a handheld gaming console. My next choice would be SNES.

My first console was a PlayStation, at Christmas 1998 (I think it was then - came with the original Spyro the Dragon, and I can remember buying the second when it came out in 1999). As such, I never actually played on other consoles. Got a PS2 around 2002, then a PS3 on the EU launch day. The first console I played on that wasn't part of the PlayStation family was an Xbox 360 at a friend's in the run up to the PS3 launch.

Pretty much what happened to me. Spyro propelled me into the Playstation genre of games. Frogger, Crash Bandicoot, ThunderStrike, Croc, they all elicit fond memories among others.

I had also found a Gameboy Color with Donkey Kong Country in it around this time which got me into handheld gaming. So that has to be my second favorite. Still remember all those car rides playing Pokemon.